great thanks gonna re-roll it tonight.
LieGrue,strub
    On Wednesday, 27 February 2019, 14:57:39 CET, Raymond Auge 
<[email protected]> wrote:  
 
 Hey Mark, I made a commit that does all of the above if you just want to take 
it.
- Ray

On Wed, Feb 27, 2019 at 12:56 AM Mark Struberg <[email protected]> wrote:

Thanks for the catch folks!

Yes we should fix the version. But we should keep it provided scoped.

txs and LieGrue,
strub


> Am 27.02.2019 um 06:45 schrieb Romain Manni-Bucau <[email protected]>:
> 
> -1 to get osgi dep in compile scope, it must always be provided cause we rely 
> on these jars in not osgi env too and old locator was always used if 
> available only, not imposed. Think we should keep this mindset.
> 
> Le mer. 27 févr. 2019 à 00:17, Raymond Auge <[email protected]> a 
> écrit :
> If you wish I could commit all of the above.
> 
> - Ray
> 
> On Tue, Feb 26, 2019 at 6:16 PM Raymond Auge <[email protected]> wrote:
> Hey Mark,
> 
> This is not a -1 but maybe a +0 due to I'd have liked to see a few changes:
> 
> - The exported package versions being updated
> - use official OSGi dependencies rather than the deprecated felix ones
> - the osgi.contract version wasn't amended to add 2.2
> - don't use the old geronimo-osgi-locator in favour of Service Loader Mediator
> 
> Sincerely,
> - Ray
> 
> 
> On Tue, Feb 26, 2019 at 5:07 PM Mark Struberg <[email protected]> wrote:
> hi folks!
> 
> I'd like to call a VOTE on releaseing the JPA-2.2 api.
> I've updated all missing parts and did verify with the signets against the 
> official jar.
> 
> Here is the staging repo:
> https://repository.apache.org/content/repositories/orgapachegeronimo-1095
> 
> The source release zip can be found here:
> https://repository.apache.org/content/repositories/orgapachegeronimo-1095/org/apache/geronimo/specs/geronimo-jpa_2.2_spec/1.0/
> the sha1 is 1d9697c65938adae1cd4ef6da78108de9904133f.
> 
> 
> So please VOTE:
> 
> [+1] lets ship it
> [+0] meh, don't care
> [-1] stop there is a $showstopper
> 
> The VOTE is open for 72h
> 
> txs and LieGrue,
> strub
> 
> 
> 
> -- 
> Raymond Augé (@rotty3000)
> Senior Software Architect Liferay, Inc. (@Liferay)
> Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)
> 
> 
> -- 
> Raymond Augé (@rotty3000)
> Senior Software Architect Liferay, Inc. (@Liferay)
> Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)




-- 
Raymond Augé (@rotty3000)Senior Software Architect Liferay, Inc. 
(@Liferay)Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)  

Reply via email to