[
https://issues.apache.org/jira/browse/GERONIMO-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875172#comment-16875172
]
Romain Manni-Bucau commented on GERONIMO-6736:
----------------------------------------------
Hmm what you copied paste justifies our impl IMHO. Smallrye has a lot of bugs
too and is not compatible with app server AND cdi at the same time so not sure
it can be used as a reference ;).
> geronimo-health provides by detault /health endpoint without
> application(endpoint) prefix
> -----------------------------------------------------------------------------------------
>
> Key: GERONIMO-6736
> URL: https://issues.apache.org/jira/browse/GERONIMO-6736
> Project: Geronimo
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Cesar Hernandez
> Assignee: Romain Manni-Bucau
> Priority: Major
> Fix For: Health_1.0.2
>
>
> Currently, if MicroProfile health endpoint has the following URL:
> `http://localhost:8080/myapp/health`
> Assuming that the JAX-RS application contains the following Application
> definition:
>
> {code:java}
> @ApplicationPath("/data")
> public class MpconfigRestApplication extends Application {
> }{code}
>
>
> The MicroProfile health
> [specification|https://github.com/eclipse/microprofile-health/releases/download/2.0.1/microprofile-health-spec.pdf]
> states:
>
> {code:java}
> Integration with CDI
> Any enabled bean with a bean of type
> org.eclipse.microprofile.health.HealthCheck and @Liveness,
> @Readiness or @Health qualifier can be used as health check procedure.
> Contextual references of health check procedures are invoked by runtime when
> the outermost
> protocol entry point (i.e. http://HOST:PORT/health) receives an inbound
> request
> @ApplicationScoped
> public class MyCheck implements HealthCheck {
> public HealthCheckResponse call() {
> [...]
> }
> {code}
>
> It seems current TCK is missing the enforce of the URL format:
> {code:java}
> http://HOST:PORT/health{code}
>
> The rest of the implementation, apart from Geronimo, had followed the
> approach defined in the specification since the first version.
> I think if geronimo add this URL format as the default it would increase his
> adoption since the current default behavior
> `http://localhost:8080/myapp/health` feels not-specification compliant.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
