chberger opened a new pull request #2: Batchee 139 URL: https://github.com/apache/geronimo-batchee/pull/2 Hi @rmannibucau, this PR contains two commits: The first one bundles all changes required to get the existing junit tests passing with the JPAPersistenceManagerService enabled. Fun fact: While doing so, I've also found a bug in the CheckpointEntity which I've fixed as well. The second commit addresses the issue described in #BATCHEE-139. I've added a couple of tests and adopted the JPAPersistenceManagerService. However, I'm not familiar with your coding conventions, so I'm not sure if it's ok to throw a NoSuchJobExecutionException in the JPA service directly. Personally, I would not do this because the JPA layer should not be aware of batch framework stuff. Anyway, since some other code was doing it already I went for the same. Please let me know if the PR is fine. Would be cool to see my code being merged :-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
