rmannibucau commented on code in PR #7: URL: https://github.com/apache/geronimo-jwt-auth/pull/7#discussion_r1484308348
########## src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/jwt/KidMapper.java: ########## @@ -161,4 +161,23 @@ private List<JWK> loadJwkSet(String url) { throw new IllegalArgumentException(e); } } + + private List<JWK> parseKeys(JsonArray keys) { + List<JWK> parsedKeys = new ArrayList<>(keys.size()); Review Comment: > return keys.stream() > .map(JsonValue::asJsonObject) > .map(JWK::new) > .filter(it -> Objects.equals("sig", it.getUse()) or it.getUse() == null /*i consider null as ok but fine to ignore it too for me*/) // no need of optional there plus the lazy creation is always done > .collect(toList()); ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org