ArneLimburg commented on code in PR #7: URL: https://github.com/apache/geronimo-jwt-auth/pull/7#discussion_r1562544797
########## src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/jwt/KidMapper.java: ########## @@ -79,9 +101,48 @@ private void init() { .collect(Collectors.toSet())) .orElseGet(HashSet::new); ofNullable(config.read("issuer.default", config.read(Names.ISSUER, null))).ifPresent(defaultIssuers::add); + jwksUrl = config.read("mp.jwt.verify.publickey.location", null); + readerFactory = Json.createReaderFactory(emptyMap()); + ofNullable(jwksUrl).ifPresent(url -> { + HttpClient.Builder builder = HttpClient.newBuilder(); + if (getJwksRefreshInterval() != null) { + long secondsRefresh = getJwksRefreshInterval(); + backgroundThread = Executors.newSingleThreadScheduledExecutor(); Review Comment: OK, I guess I am not so into the Executor/ThreadFactory stuff. How should this look exactly and why would that help? Maybe we should put the creation of the Executor in a separate protected method anyway, to allow overriding and using other Executor, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org