[ https://issues.apache.org/jira/browse/GIRAPH-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402483#comment-13402483 ]
Jakob Homan commented on GIRAPH-213: ------------------------------------ NettyClient.stop() itself should be synchronous, correct? It looks like this moves all the closing connections to asynch. Do we need to wait for them to return before returning from stop? > NettyClient.stop() could deadlock according to netty.io docs > ------------------------------------------------------------ > > Key: GIRAPH-213 > URL: https://issues.apache.org/jira/browse/GIRAPH-213 > Project: Giraph > Issue Type: Improvement > Affects Versions: 0.2.0 > Reporter: Eli Reisman > Assignee: Eli Reisman > Priority: Trivial > Fix For: 0.2.0 > > Attachments: GIRAPH-213-1.patch > > > NettyClient.stop() does not follow netty.io best practices and could > potentially deadlock? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira