[
https://issues.apache.org/jira/browse/GIRAPH-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403390#comment-13403390
]
Jakob Homan commented on GIRAPH-216:
------------------------------------
This looks good, but I'd like a small test to guard against regressions.
> NullWritable as VertexData, EdgeData or MessageData should be allowed
> ---------------------------------------------------------------------
>
> Key: GIRAPH-216
> URL: https://issues.apache.org/jira/browse/GIRAPH-216
> Project: Giraph
> Issue Type: Bug
> Reporter: Jan van der Lugt
> Assignee: Jan van der Lugt
> Attachments: GIRAPH-216.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using NullWritable as VertexData, EdgeData or MessageData, an error
> occurs. This happens because the constructor of NullWritable is private, so
> ReflectionUtils.newInstance() fails. The solution is checking for
> NullWritable separately, and then returning NullWritable.get() instead of a
> new class. This can save very large amounts of memory, since NullWritable is
> a singleton.
> This was reported on the mailing list, but never fixed:
> http://mail-archives.apache.org/mod_mbox/incubator-giraph-user/201112.mbox/%3c4eded788.4020...@apache.org%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
