[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404936#comment-13404936
]
Hudson commented on GIRAPH-221:
-------------------------------
Integrated in Giraph-trunk-Commit #133 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/133/])
GIRAPH-221: Make iteration over edges more explicit (apresta via aching).
(Revision 1356104)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356104
Files :
* /giraph/trunk/CHANGELOG
*
/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
*
/giraph/trunk/src/main/java/org/apache/giraph/examples/ConnectedComponentsVertex.java
*
/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
*
/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
*
/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleTriangleClosingVertex.java
* /giraph/trunk/src/main/java/org/apache/giraph/examples/VerifyMessage.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/HashMapVertex.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java
*
/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
*
/giraph/trunk/src/main/java/org/apache/giraph/lib/AdjacencyListTextVertexOutputFormat.java
*
/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonBase64VertexOutputFormat.java
*
/giraph/trunk/src/main/java/org/apache/giraph/lib/JsonLongDoubleFloatDoubleVertexOutputFormat.java
* /giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
*
/giraph/trunk/src/test/java/org/apache/giraph/lib/TestAdjacencyListTextVertexOutputFormat.java
*
/giraph/trunk/src/test/java/org/apache/giraph/lib/TestIdWithValueTextOutputFormat.java
*
/giraph/trunk/src/test/java/org/apache/giraph/lib/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
> Make iteration over edges more explicit
> ---------------------------------------
>
> Key: GIRAPH-221
> URL: https://issues.apache.org/jira/browse/GIRAPH-221
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-221-1.patch, GIRAPH-221-2.patch
>
>
> Is there any particular reason why BasicVertex implements Iterable?
> It seems to me that doing
> {code:java}
> for (I neighbor : vertex)
> {code}
> is not that explicit, and
> {code:java}
> for (I neighbor : this)
> {code}
> gets even obscure (which may be why all examples in the codebase explicitly
> instantiate an iterator and call next()).
> What I propose is a more explicit
> {code:java}
> Iterator<I> outEdgesIterator()
> {code}
> and also a convenient
> {code:java}
> Iterable<I> outEdges()
> {code}
> so, for example, an algorithm can use
> {code:java}
> for (IntWritable neighbor : outEdges())
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
