[ https://issues.apache.org/jira/browse/GIRAPH-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449342#comment-13449342 ]
Eli Reisman commented on GIRAPH-314: ------------------------------------ FYI: The "nightmare scenario" described above is the message growth, not combiners! ;) The general thinking there is by grouping the messages we eliminate the need on the sending side, and on the receive side the chances of an identical grouped message of this sort to be sent to the same partition destination vertices more than once is very rare and not driving the duplication. But I'm open to thoughts on the matter! The "stage 2" stuff is getting run and tweaked right now, any eventual version will need to pass muster (and evolve to play nice with) with Maya's new message store system and probably be generally pluggable by use case regardless. More to follow on that JIRA (when I post it) > Implement better message grouping to improve performance in > SimpleTriangleClosingVertex > --------------------------------------------------------------------------------------- > > Key: GIRAPH-314 > URL: https://issues.apache.org/jira/browse/GIRAPH-314 > Project: Giraph > Issue Type: Improvement > Components: examples > Affects Versions: 0.2.0 > Reporter: Eli Reisman > Assignee: Eli Reisman > Priority: Trivial > Fix For: 0.2.0 > > Attachments: GIRAPH-314-1.patch, GIRAPH-314-2.patch, > GIRAPH-314-3.patch, GIRAPH-314-4.patch > > > After running SimpleTriangleClosingVertex at scale I'm thinking the > sendMessageToAllEdges() is pretty in the code, but its not a good idea in > practice since each vertex V sends degree(V)^2 messages right in the first > superset in this algorithm. Could do something with a combiner etc. but just > grouping messages by hand at the application level by using > IntArrayListWritable again does the trick fine. > Probably should have just done it this way before, but > sendMessageToAllEdges() looked so nice. Sigh. Changed unit tests to reflect > this new approach, passes mvn verify and cluster, etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira