----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7762/#review12888 -----------------------------------------------------------
Thanks Nitay, this is a nice feature to have. I like that you pulled out counters to separate classes. But why do you use static instances of these classes, can't you have them as fields of BspServiceMaster/MasterThread? Also, it would be nicer if postApplication wasn't called from inside cleanup. - Maja Kabiljo On Oct. 29, 2012, 5:20 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7762/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2012, 5:20 p.m.) > > > Review request for giraph. > > > Description > ------- > > GIRAPH-390: MasterCompute postApplication callback. > > > Diffs > ----- > > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java > d68debc41b44e20c0dcb5907d1a1b398b759b149 > giraph/src/main/java/org/apache/giraph/graph/MasterCompute.java > 9de23ad4a7781d6342339f26f44fb1c1d9bce2b0 > giraph/src/main/java/org/apache/giraph/graph/MasterThread.java > 85842d0ab59330d95b843c440f2d5705b41e0d1b > giraph/src/main/java/org/apache/giraph/metrics/GiraphHadoopCounter.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/metrics/GiraphStats.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/metrics/GiraphTimers.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/metrics/HadoopCountersBase.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/metrics/package-info.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/7762/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
