[ 
https://issues.apache.org/jira/browse/GIRAPH-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495576#comment-13495576
 ] 

Nitay Joffe commented on GIRAPH-418:
------------------------------------

The patch looks okay but there are a few things I would ask to change:
1) You are disabling having hadoop_0.20.203 as the active profile by default 
and enabling your CDH version as the default hadoop. I don't think we want 
this. You should use -P2.0.0-cdh4.1.2 when building your profile instead and 
leave the default.
2) Please put the <version> numbers for the dependencies in the 
<dependencyManagement>. Also please use a variable as you are reusing 
"2.0.0-cdh4.1.2" many times.
3) There seems to be some weird spacing, do you have some tabs in there?
4) Remove <hadoop.version> in top level properties, shouldn't be there.
5) You added bunch of spaces in <repositories> doesn't seem to be clearer to 
read to me, is there a reason for this? 
                
> Create maven profile for CDH 4.1.1
> ----------------------------------
>
>                 Key: GIRAPH-418
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-418
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Eugene Koontz
>         Attachments: GIRAPH-418.patch, pom.xml
>
>
> Mirko writes:
> bq. Hello all,
> bq. I created a now pom.xml file, which allows compiling Giraph with the new 
> CDH 4.1.2 repository.
> bq. I attached it to this email.
> bq. But there are still some problems. I can not start the examples, because 
> I do not have demo data and I do not jet know, what formats have to be used. 
> Has anybody some test data files to share for a public tutorial?
> bq. Currently I prepare a tutorial on working with Giraph, but until now I 
> had to find out, that the wiki content is quite outdated. The 
> ShortestPathExample looks nice, but without some hints I can not start. Did I 
> miss some documentation? If not, I will create it, but therefor I would like 
> to ask for some help.
> bq. My plan is, to create some demo data files and some Demo-Apps comparable 
> to the benchmark classes but based on real data. I have some correlation 
> obtained from wikipedia user data, but until now I can not analuse that data 
> with Giraph.
> bq. I get the following error ( at the end of this mail ) if I want to start 
> the PageRankBenchmark.
> bq. Has anybody an idea, what I can do to solve this problem?
> bq. Thanks a lot!
> bq. Best wishes
> bq. Mirko

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to