----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8042/#review13535 -----------------------------------------------------------
This is a very useful thing to have, thanks Nitay. Is it possible to keep the timing logic together? (this mostly exists from the previous metrics patch, but I didn't take a look at it back then) I think that ideally we would have some timer class, which would keep the time unit used and its name within itself. It would also have some functions like start() and stop(), first of which would be saving the current time, and the second would be calculating the time elapsed. I think that's nicer than having time measurement code everywhere. What do you think? /trunk/giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java <https://reviews.apache.org/r/8042/#comment29021> Revisit the comments - Maja Kabiljo On Nov. 16, 2012, 8:18 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8042/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 8:18 p.m.) > > > Review request for giraph. > > > Description > ------- > > GIRAPH-421: Aggregate metrics up to master > > > Diffs > ----- > > /trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java > 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java > 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java > 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java > 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/metrics/AggregatedMetric.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/AggregatedMetrics.java > PRE-CREATION > /trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java > 1409973 > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java > 1409973 > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/MetricsRegistryDebugger.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/SuperstepMetricsRegistry.java > 1409973 > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/ValueWithHostname.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetrics.java > PRE-CREATION > /trunk/giraph/src/main/java/org/apache/giraph/utils/FakeTime.java 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/utils/SystemTime.java 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/utils/Time.java 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/utils/Times.java 1409973 > /trunk/giraph/src/main/java/org/apache/giraph/utils/WritableUtils.java > 1409973 > > Diff: https://reviews.apache.org/r/8042/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
