----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8437/#review14416 -----------------------------------------------------------
+1, I like the refactoring. I also agree that it would be better for the various options to live in the relevant classes (e.g., netty server options in NettyServer). /trunk/giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java <https://reviews.apache.org/r/8437/#comment30703> Nice. /trunk/giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java <https://reviews.apache.org/r/8437/#comment30709> Nice. - Alessandro Presta On Dec. 10, 2012, 2:01 a.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8437/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 2:01 a.m.) > > > Review request for giraph. > > > Description > ------- > > https://issues.apache.org/jira/browse/GIRAPH-447 > > > Diffs > ----- > > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/accumulo/AccumuloVertexInputFormat.java > 1419098 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hbase/HBaseVertexInputFormat.java > 1419098 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java > 1419098 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexOutputFormat.java > 1419098 > > /trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java > 1419098 > > /trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/GiraphRunner.java 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/GraphStateAware.java 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfigurable.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/bsp/BspInputFormat.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/comm/SendMessageCache.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/comm/SendPartitionCache.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/comm/ServerData.java 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/aggregators/AggregatorUtils.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/messages/ByteArrayMessagesPerVertexStore.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/messages/DiskBackedMessageStore.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/messages/SequentialFileMessageStore.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyClient.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyMasterClient.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyMasterServer.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyServer.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerAggregatorRequestProcessor.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/MasterRequestServerHandler.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/RequestDecoder.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/SaslServerHandler.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/WorkerRequestReservedMap.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/netty/handler/WorkerRequestServerHandler.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/comm/requests/WritableRequest.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/conf/GiraphClasses.java > PRE-CREATION > /trunk/giraph/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java > PRE-CREATION > /trunk/giraph/src/main/java/org/apache/giraph/conf/GiraphConstants.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfigurable.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java > PRE-CREATION > /trunk/giraph/src/main/java/org/apache/giraph/conf/package-info.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspService.java 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/BspUtils.java 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/ComputeCallable.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/DefaultVertexResolver.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeInputSplitsCallable.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/EdgeInputSplitsCallableFactory.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphJob.java 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/GraphStateAware.java > PRE-CREATION > > /trunk/giraph/src/main/java/org/apache/giraph/graph/InputSplitsCallable.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/MasterAggregatorHandler.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/MasterCompute.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/MasterThread.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/Vertex.java 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexInputSplitsCallable.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexInputSplitsCallableFactory.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexMutations.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexResolver.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/graph/VertexValueReader.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/WorkerAggregatorHandler.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/BasicPartitionOwner.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/ByteArrayPartition.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/DiskBackedPartitionStore.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/GraphPartitionerFactory.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashMasterPartitioner.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashPartitionerFactory.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/HashRangePartitionerFactory.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/Partition.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/RangeSplitHint.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/SimplePartition.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/graph/partition/SimplePartitionStore.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/integration/SuperstepHashPartitionerFactory.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/io/PseudoRandomVertexInputFormat.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/io/TextEdgeInputFormat.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/io/TextVertexInputFormat.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/master/DefaultMasterObserver.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/master/MasterObserver.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/metrics/SuperstepMetricsRegistry.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/utils/ByteArrayIterable.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/utils/ByteArrayIterator.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/utils/ByteArrayVertexIdMessages.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/utils/ReflectionUtils.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/utils/RepresentativeByteArrayIterable.java > 1419098 > > /trunk/giraph/src/main/java/org/apache/giraph/utils/RepresentativeByteArrayIterator.java > 1419098 > /trunk/giraph/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/BspCase.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestAutoCheckpoint.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestBspBasic.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestEdgeInput.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestGiraphConfiguration.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestGraphPartitioner.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestJsonBase64Format.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestManualCheckpoint.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestMasterObserver.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestMutateGraph.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestPageRank.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/TestVertexTypes.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/comm/ConnectionTest.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/comm/RequestFailureTest.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/comm/RequestTest.java 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/comm/TestMessageStores.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/graph/TestAggregatorsHandling.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/graph/TestMutableVertex.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/graph/partition/TestPartitionStores.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java > 1419098 > > /trunk/giraph/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/utils/BspUtilsTest.java > 1419098 > /trunk/giraph/src/test/java/org/apache/giraph/utils/MockUtils.java 1419098 > /trunk/giraph/src/test/java/zk/TestZooKeeperManager.java 1419098 > > Diff: https://reviews.apache.org/r/8437/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
