[
https://issues.apache.org/jira/browse/GIRAPH-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530813#comment-13530813
]
Giraph QA commented on GIRAPH-141:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12560708/GIRAPH-141.patch
against trunk revision 1419623.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified test
files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The applied patch does not increase the total number of
javadoc warnings.
+1 checkstyle. The patch generated 0 code style errors.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
-1 release audit. The applied patch generated 1 release audit warnings.
+1 core tests. The patch passed unit tests in giraph
giraph-formats-contrib.
Test results:
https://builds.apache.org/job/PreCommit-GIRAPH-Build/45//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-GIRAPH-Build/45//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-GIRAPH-Build/45//console
This message is automatically generated.
> multigraph support in giraph
> ----------------------------
>
> Key: GIRAPH-141
> URL: https://issues.apache.org/jira/browse/GIRAPH-141
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Reporter: André Kelpe
> Assignee: Alessandro Presta
> Attachments: GIRAPH-141.patch, GIRAPH-141.patch
>
>
> The current vertex API only supports simple graphs, meaning that there can
> only ever be one edge between two vertices. Many graphs like the road network
> are in fact multigraphs, where many edges can connect two vertices at the
> same time.
> Support for this could be added by introducing an Iterator<EdgeWritable>
> getEdgeValue() or a similar construct. Maybe introducing a slim object like a
> Connector between the edge and the vertex is also a good idea, so that you
> could do something like:
> {code}
> for (final Connector<EdgeWritable, VertexWritable> conn: getEdgeValues(){
> final EdgeWritable edge = conn.getEdge();
> final VertexWritable otherVertex = conn.getOther();
> doInterestingStuff(otherVertex);
> doMoreInterestingStuff(edge);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
