[ 
https://issues.apache.org/jira/browse/GIRAPH-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547595#comment-13547595
 ] 

Alessandro Presta commented on GIRAPH-474:
------------------------------------------

Your patch file looks weird...
I see you set the default to true. I think it should be false. Since this has 
proven to be unsafe, it should be considered experimental.
                
> Add an option not to use direct byte buffers
> --------------------------------------------
>
>                 Key: GIRAPH-474
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-474
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-474.patch
>
>
> Using direct byte buffers makes it harder to control the memory used by 
> giraph. It's a bit faster than regular buffers though (from some experiments 
> I run the difference was about 10%), so I am adding it as an option. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to