[
https://issues.apache.org/jira/browse/GIRAPH-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599619#comment-13599619
]
Eli Reisman commented on GIRAPH-479:
------------------------------------
YARN can launch the zk process from the app manager, and populate zkList to
signal Giraph not to launch a ZK instance itself. So this is not strictly
required for GIRAPH-13. So, if anyone thinks a refactor here is helpful, I can
rebase it. Otherwise we can resolve won't fix.
> Factor creation of job-local ZooKeeper instances out of ZKManager to enable
> YARN instantiation, etc.
> ----------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-479
> URL: https://issues.apache.org/jira/browse/GIRAPH-479
> Project: Giraph
> Issue Type: Improvement
> Components: zookeeper
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Minor
> Attachments: GIRAPH-479-1.patch, GIRAPH-479-2.patch,
> GIRAPH-479-3.patch, GIRAPH-479-4.patch
>
>
> When the user does not specify a ZooKeeper quorum to run Giraph on, the
> ZooKeeperManager creates one. This factors out the boilerplate that handles
> this additional process and its lifecycle so that various pluggable versions
> of this process instantiation can be implemented and fed to the ZKManager via
> a factory depending on the nature of the underlying cluster.
> By implementing the ZooKeeperProcessBuilder interface, one will now be able
> to implement the creation/mangement of a new, job-local ZK instance using any
> underlying resourcing mechanism one chooses (including, I hope, YARN.)
> Passes mvn verify, etc.
> Review board link:
> https://reviews.apache.org/r/8948/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
