-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10285/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Benchmark classes have a lot of duplicate options and duplicate code which 
handles CommandLine.


This addresses bug giraph-604.
    https://issues.apache.org/jira/browse/giraph-604


Diffs
-----

  
giraph-core/src/main/java/org/apache/giraph/benchmark/AggregatorsBenchmark.java 
7043338 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/benchmark/GiraphBenchmark.java 
PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java 
b5d7e1e 
  
giraph-core/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
 ff65ab9 
  
giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java
 c3c714e 

Diff: https://reviews.apache.org/r/10285/diff/


Testing
-------

mvn clean install, run a few benchmarks


Thanks,

Maja Kabiljo

Reply via email to