[ https://issues.apache.org/jira/browse/GIRAPH-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689695#comment-13689695 ]
Nitay Joffe commented on GIRAPH-623: ------------------------------------ I see okay. I don't like having multiple constructors because it makes it unclear how to use it. How about we clean up the interface a bit and use Builders (e.g. http://rwhansen.blogspot.com/2007/07/theres-builder-pattern-that-joshua.html). I noticed a lot of the Options use the "default" default-value, like null for example, so this could clean all those calls up. Will you take on this cleanup? We can do it in a separate JIRA if you like. > Website Documentation: table of parameters > ------------------------------------------ > > Key: GIRAPH-623 > URL: https://issues.apache.org/jira/browse/GIRAPH-623 > Project: Giraph > Issue Type: Improvement > Reporter: Claudio Martella > Attachments: GIRAPH-623.patch > > > Would be nice to have a table with all the parameters in GiraphConstants, > with defaults and relative javadoc explanation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira