[ 
https://issues.apache.org/jira/browse/GIRAPH-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maja Kabiljo updated GIRAPH-721:
--------------------------------

    Attachment: GIRAPH-721.patch

I'll check if there are other places where the same thing applies. Basically 
wherever we run something using ProgressableUtils, it's not required to call 
progress. But it only matters for the places where we call it a lot (per edge, 
or for very low-degree graphs per vertex).
                
> Don't call progress on each edge/vertex loaded
> ----------------------------------------------
>
>                 Key: GIRAPH-721
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-721
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-721.patch
>
>
> While loading data with edge input, we call context.progress() on each edge. 
> I was experimenting with where cpu is going during the input with hundreds of 
> billions of edges, and about 10% of it is just calling progress. We don't 
> need to call progress here at all, since the main thread which waits on input 
> threads to finish does that for us.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to