[
https://issues.apache.org/jira/browse/GIRAPH-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745892#comment-13745892
]
Claudio Martella commented on GIRAPH-743:
-----------------------------------------
patch looks good, but does not match coding style conventions (e.g. lines are
longer than 80 chars).
> DiskBackedPartitionStore needs file existence checks around file deletion and
> directory creation
> ------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-743
> URL: https://issues.apache.org/jira/browse/GIRAPH-743
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 1.1.0
> Reporter: Craig Muchinsky
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: GIRAPH-743.patch
>
>
> The changes made to DiskBackedPartitionStore with GIRAPH-736 introduced
> return code checks on File.delete() and File.mkdirs() calls, and if they are
> unsuccessful it is logged as an ERROR. This really only makes sense if the
> file already exists or the directory doesn't exist respectively. In addition
> to these checks, the ERROR messages that are logged should use the absolute
> file path instead of the relative path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
