[ https://issues.apache.org/jira/browse/GIRAPH-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887351#comment-13887351 ]
Eli Reisman commented on GIRAPH-747: ------------------------------------ Had a chance to look again and my read is this breaks non-YARN. We might need to adjust this patch to use another method. I do think this is a real issue and we should get something in to fix it. > BspServiceMaster finishes ZooKeeper cleanup without waiting for all workers > to complete > --------------------------------------------------------------------------------------- > > Key: GIRAPH-747 > URL: https://issues.apache.org/jira/browse/GIRAPH-747 > Project: Giraph > Issue Type: Bug > Affects Versions: 1.0.0 > Reporter: Chuan Lei > Assignee: Chuan Lei > Fix For: 1.0.0 > > Attachments: GIRAPH-747.v1.patch > > > In BspServiceMaster, the function cleanUpZooKeeper should wait for the number > of workers and masters to complete. However, it appears that maxTasks only > takes workers into consideration. Consequently, the worker straggler may fail > to report to the ZooKeeper due to the path gets removed too early. This will > cause No lease on path File does not exist exception at runtime. -- This message was sent by Atlassian JIRA (v6.1.5#6160)