[ https://issues.apache.org/jira/browse/GIRAPH-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889687#comment-13889687 ]
Hudson commented on GIRAPH-839: ------------------------------- ABORTED: Integrated in Giraph-trunk-Commit #1403 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1403/]) GIRAPH-839: NettyWorkerAggregatorRequestProcessor tries to reuse request objects (pavanka via majakabiljo) (majakabiljo: http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=9325fa9869c2604172576f89311308915ebb416d) * CHANGELOG * giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerAggregatorRequestProcessor.java > NettyWorkerAggregatorRequestProcessor tries to reuse request objects > -------------------------------------------------------------------- > > Key: GIRAPH-839 > URL: https://issues.apache.org/jira/browse/GIRAPH-839 > Project: Giraph > Issue Type: Bug > Reporter: Pavan Kumar > Assignee: Pavan Kumar > Attachments: GIRAPH-839.patch > > > I was working on upgrading netty to 4.0.14.Final. It is mostly done, after > some polishing I will submit a patch for that soon. > While working on the above, I discovered a bug in > NettyWorkerAggregatorRequestProcessor. The distributeAggregators method is > reusing SendAggregatorsToWorkerRequest objects, which is incorrect since each > task has a different task id & (potentially a different) request id. It does > not cause any problem with current netty but in the new version I guess due > to delayed serialization the object cannot be reused. > Anyway, moving it inside the for loop does not cause any issues with current > netty as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)