[
https://issues.apache.org/jira/browse/GIRAPH-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924269#comment-13924269
]
Pavan Kumar commented on GIRAPH-868:
------------------------------------
+l LGTM
Thanks for the fix
small comments:
can the definition be changed from
stop(String myProgressPath, ZooKeeperExt zk) to
stop(ZooKeeperExt zk, String myProgressPath) since writeToZnode has similar
definition and it would be less confusing that way.
also did u run checkstyle
+ public void stop(String myProgressPath, ZooKeeperExt zk) throws
+ InterruptedException {
please run mvn clean verify before checking in.
> Fix race condition with WorkerProgress
> --------------------------------------
>
> Key: GIRAPH-868
> URL: https://issues.apache.org/jira/browse/GIRAPH-868
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-868.patch
>
>
> WorkerProgressWriter periodically updates progress and it can happen that it
> overwrites the finished state written from the main thread, causing job
> client to wait indefinitely.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
