----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19401/ -----------------------------------------------------------
Review request for giraph. Repository: giraph-git Description ------- This patch converts the EdgeStore class to an interface and adds 3 impls: SimpleEdgeStore: same behavior as original EdgeStore class IntEdgeStore: edge store optimized for integer ids, uses fastutil primitive collections and allows reuse of vertexId objects (which is the big performance win) LongEdgeStore: edge store optimized for long ids, uses fastutil primitive collections and allows reuse of vertexId objects (which is the big performance win) The impl to use is chosen programmatically based on interrogation of the id class type. In the future perhaps the EdgeStore impl could be specified via configuration, to allow extensibility. Diffs ----- giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java 39bf504 giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java dd8f2a3 giraph-core/src/main/java/org/apache/giraph/edge/SimpleEdgeStore.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/edge/primitives/IntEdgeStore.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/edge/primitives/LongEdgeStore.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/edge/primitives/package-info.java PRE-CREATION Diff: https://reviews.apache.org/r/19401/diff/ Testing ------- Successful "mvn clean verify" with hadoop_2 profile, and 4B vertex 5B edge graph tested on 18 node 432 core cluster. Thanks, Craig Muchinsky
