[
https://issues.apache.org/jira/browse/GIRAPH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943826#comment-13943826
]
Hudson commented on GIRAPH-872:
-------------------------------
ABORTED: Integrated in Giraph-trunk-Commit #1433 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/1433/])
GIRAPH-872 (claudio:
http://git-wip-us.apache.org/repos/asf/?p=giraph.git&a=commit&h=01d11687dd2e89f97e0b5c557bbfd0cefb6ed625)
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java
* CHANGELOG
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java
> Minor inconsistencies with netty handler logic after netty 4 upgrade
> --------------------------------------------------------------------
>
> Key: GIRAPH-872
> URL: https://issues.apache.org/jira/browse/GIRAPH-872
> Project: Giraph
> Issue Type: Bug
> Components: bsp
> Affects Versions: 1.1.0
> Reporter: Craig Muchinsky
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: GIRAPH-872.patch
>
>
> While debugging some other issues I noticed a few minor inconsistencies and
> suspected logic bugs in the netty handler changes related to netty 4:
> 1.) Classes (RequestServerHandler, ResponseClientHandler) overriding
> ChannelInboundHandlerAdapter.exceptionCaught() are still calling getCause()
> on the passed Throwable even though what's being passed in now is the actual
> cause instead of a wrapper.
> 2.) ResponseClientHandler.channelInactive() isn't calling
> ChannelHandlerContext.fireChannelInactive() like RequestServerHandler does. I
> believe this is an oversight and not by design.
> 3.) ResponseClientHandler.exceptionCaught() is gating the LOG.warn() call
> with a LOG.isDebugEnabled() check. I suspect this gate should be removed so
> the warning gets logged properly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
