[
https://issues.apache.org/jira/browse/GIRAPH-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989128#comment-13989128
]
Hudson commented on GIRAPH-891:
-------------------------------
ABORTED: Integrated in Giraph-trunk-Commit #1439 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/1439/])
GIRAPH-891: Make MessageStoreFactory configurable (rohankarwa via majakabiljo)
(majakabiljo:
http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=dd47ce6abdf01adc3584d6e7e0d41c6749d02d30)
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/PartitionDiskBackedMessageStore.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/SequentialFileMessageStore.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/ByteArrayMessagesPerVertexStore.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java
* giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java
* CHANGELOG
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStoreFactory.java
* giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/DiskBackedMessageStore.java
* giraph-core/src/test/java/org/apache/giraph/jython/TestJythonComputation.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/out_of_core/DiskBackedMessageStoreFactory.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/InMemoryMessageStoreFactory.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
> Make MessageStoreFactory configurable
> --------------------------------------
>
> Key: GIRAPH-891
> URL: https://issues.apache.org/jira/browse/GIRAPH-891
> Project: Giraph
> Issue Type: Task
> Components: bsp
> Affects Versions: 1.1.0
> Reporter: Rohan Karwa
> Priority: Minor
> Attachments: diff_2ndmay.txt
>
>
> As mentioned in the task: 4213037
> Related to the Task:
> https://our.intern.facebook.com/intern/tasks/?s=754080093&t=4213037
> Changed the MessageStoreFactory interface and added a new method
> "initialize(service, config)" in order to do the setting up of message store
> factory. In order to invoke the class (as per the configuration) on run time,
> reflection is used for the class invocation and then initialize() method is
> called on the instance.
> There were few classes which had private factory implementation, for these
> classes there is no need to implement the initialize() method as the class is
> never exposed and can't be passed as a configuration.
> Also, in order to make the DiskBackedMessageStore.class value to be passed
> from the configuration, I moved the implementation to the new file and made
> this class as a public class.
> Modified a test case for testing this configuration(DiskBased/InMemory Backed
> Message Stores).
> Review Link: https://reviews.apache.org/r/20915/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
