----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21151/#review42638 -----------------------------------------------------------
giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java <https://reviews.apache.org/r/21151/#comment76467> please move this to GiraphConstants and define it as boolconfoption also a supporting method like isValidatePartitioningConsitency - inside GiraphConfiguration giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java <https://reviews.apache.org/r/21151/#comment76471> isn't this supposed to be named mypartitionids? giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java <https://reviews.apache.org/r/21151/#comment76468> just do .addAll(myPartitions) giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java <https://reviews.apache.org/r/21151/#comment76469> indentation please - please run mvn clean verify for hadoop_1 & hadoop_2 giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java <https://reviews.apache.org/r/21151/#comment76470> variable name is confusion better name is destinations? giraph-core/src/main/java/org/apache/giraph/partition/HashWorkerPartitioner.java <https://reviews.apache.org/r/21151/#comment76475> isn't this already sorted inside PartitionBalancer.updatePartitionOwners giraph-core/src/main/java/org/apache/giraph/partition/PartitionBalancer.java <https://reviews.apache.org/r/21151/#comment76472> can't u just create the comparator once as a static final variable & reuse it for all method calls? giraph-core/src/main/java/org/apache/giraph/partition/SimpleWorkerPartitioner.java <https://reviews.apache.org/r/21151/#comment76474> why don't u embed this method into PartitionBalancer.updatePartitionOwners giraph-core/src/main/java/org/apache/giraph/partition/SimpleWorkerPartitioner.java <https://reviews.apache.org/r/21151/#comment76473> IllegalStateException - Pavan Kumar Athivarapu On May 7, 2014, 10:33 a.m., Lukas Nalezenec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21151/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 10:33 a.m.) > > > Review request for giraph, Avery Ching, Claudio Martella, Maja Kabiljo, pavan > kumar kolamuri, and Sebastian Schelter. > > > Repository: giraph-git > > > Description > ------- > > PartitionBalancer returns PartitionOwners in list in arbitrary order but both > Range and Hash partitioners are assuming that list is sorted by partitionId. > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java > 7ab291b > > giraph-core/src/main/java/org/apache/giraph/partition/HashWorkerPartitioner.java > d833895 > > giraph-core/src/main/java/org/apache/giraph/partition/PartitionBalancer.java > 3454d62 > > giraph-core/src/main/java/org/apache/giraph/partition/SimpleWorkerPartitioner.java > 600d7a3 > > Diff: https://reviews.apache.org/r/21151/diff/ > > > Testing > ------- > > > Thanks, > > Lukas Nalezenec > >
