[
https://issues.apache.org/jira/browse/GIRAPH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019443#comment-14019443
]
Maja Kabiljo commented on GIRAPH-911:
-------------------------------------
Tom, all user classes are created with ReflectionUtils.newInstance(klass, conf)
which sets Configuration on them - specifically for IO formats see
ImmutableClassesGiraphConfiguration.createVertexInputFormat for example.
> Calling setConf on wrapped Input and Output classses.
> ------------------------------------------------------
>
> Key: GIRAPH-911
> URL: https://issues.apache.org/jira/browse/GIRAPH-911
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Tom Schweiger
> Priority: Minor
> Labels: easyfix
> Fix For: 1.1.0
>
> Attachments: GIRAPH-911.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a set of wrappers for vertex and edge input and output format
> classes that create a copy of the class and then calls certain methods using
> a modified context. The wrapped class is configurable, but setConf is never
> called on it. If a user creates their own vertex or edge input or output
> format that requires some special set-up, they cannot rely on the the
> setConf call to achieve this in all situations; it will work for unwrapped
> instances of the class but not for the wrapped class.
> Thus for the wrapped classes there should be a setConf method that calls the
> super for the wrapper as well as setConf on the wrapped class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
