[ 
https://issues.apache.org/jira/browse/GIRAPH-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059231#comment-14059231
 ] 

Pavan Kumar commented on GIRAPH-928:
------------------------------------

just realized that this change is not necessary. there is no bug in current 
store. it works fine!

> SendWorkerMessagesRequest should not store messages into PointerList based 
> messagestores
> ----------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-928
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-928
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Pavan Kumar
>            Assignee: Pavan Kumar
>            Priority: Minor
>         Attachments: GIRAPH-928, GIRAPH-928.patch
>
>
> While running some test jobs I realized that after GIRAPH-912, some old logic 
> inside SendOneMessageToManyCache can cause a situation where 
> SendWorkerMessagesRequest try to store messages into PointerList based 
> messagestores. This is semantically incorrect. So the code needs to be 
> refactored to remove this possibility. Also adding sanity checks which can be 
> removed later if felt redundant.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to