[
https://issues.apache.org/jira/browse/GIRAPH-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278039#comment-14278039
]
Sergey Edunov commented on GIRAPH-882:
--------------------------------------
Lee, thank you for working on this!
Please make sure you follow the steps
http://giraph.apache.org/generating_patches.html
In particular, you need to run mvn clean verify. It looks like your change
actually breaks unit tests.
It is also recommended to submit review board request or phabricator code
review for big patches (this one seems big enough). I submitted one for you:
https://reviews.facebook.net/D31563 and put some comments there.
Also you should be working against latest version of Giraph from git, I was
able to merge your changes, but the more complicated your patch is, the harder
it will be to merge.
> List of zookeeper connection strings is trimmed by Hadoop counters.
> -------------------------------------------------------------------
>
> Key: GIRAPH-882
> URL: https://issues.apache.org/jira/browse/GIRAPH-882
> Project: Giraph
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 1.1.0
> Reporter: Lukas Nalezenec
> Attachments: GIRAPH-882.patch, testrun.log
>
>
> We are running job with quorum of 3 zookeepers. Each serves has got long name
> (turing452.fi.callan.de:22181). Connection strings are stored to Hadoop
> Counters (for example:
> turing452.fi.callan.de:22181,turing124.fi.callan.de:22181,turing488.fi.callan.de:22181)
> but since name of counter is limited to ~63 character the connection string
> is trimmed (turing452.fi.callan.de:22181,turing124.fi.callan.de:22181,turin).
> 14/03/18 23:44:41 INFO zookeeper.ZooKeeper: Client
> environment:user.name=hadoop
> 14/03/18 23:44:41 INFO zookeeper.ZooKeeper: Initiating client connection,
> connectString=turing452.fi.callan.de:22181,turing124.fi.callan.de:22181,turin
> sessionTimeout=60000
> Exception in thread "main" java.net.UnknownHostException: turin
> at java.net.Inet4AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$1.lookupAllHostAddr(InetAddress.java:901)
> at
> java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1293)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1246)
> at java.net.InetAddress.getAllByName(InetAddress.java:1162)
> at java.net.InetAddress.getAllByName(InetAddress.java:1098)
> at
> org.apache.zookeeper.client.StaticHostProvider.<init>(StaticHostProvider.java:60)
> at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:445)
> at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:380)
> at org.apache.giraph.zk.ZooKeeperExt.<init>(ZooKeeperExt.java:114)
> at
> org.apache.giraph.job.JobProgressTracker.<init>(JobProgressTracker.java:69)
> at org.apache.giraph.job.GiraphJob.run(GiraphJob.java:255)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
