[ 
https://issues.apache.org/jira/browse/GIRAPH-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dionysios Logothetis updated GIRAPH-996:
----------------------------------------
    Attachment: GIRAPH-996.patch

I moved the checks inside NettyClient. The warning also prints the class name 
of the WritableRequest, to be able to distinguish. I omitted printing to 
command line as it required passing the WorkerContext from BspServiceMaster to 
NettyMasterClient to NettyClient, probably not worth the refactoring. Besides, 
this might result in a lot of output to the command line.

> Large requests degrade performance. Print out warnings.
> -------------------------------------------------------
>
>                 Key: GIRAPH-996
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-996
>             Project: Giraph
>          Issue Type: Task
>            Reporter: Dionysios Logothetis
>            Assignee: Dionysios Logothetis
>            Priority: Minor
>         Attachments: GIRAPH-996.patch
>
>
> Sometimes performance degrades significantly or a job starts using too much 
> off heap memory when requests larger than expected are being sent through 
> netty. We should print warnings when large requests are sent, and also send 
> warnings to command line to make sure users notice them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to