[ https://issues.apache.org/jira/browse/GIRAPH-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258591#comment-15258591 ]
Hassan Eslami commented on GIRAPH-1057: --------------------------------------- https://reviews.facebook.net/D56367 > Decoupling NettyClient from control flow policy > ----------------------------------------------- > > Key: GIRAPH-1057 > URL: https://issues.apache.org/jira/browse/GIRAPH-1057 > Project: Giraph > Issue Type: Improvement > Reporter: Hassan Eslami > Assignee: Hassan Eslami > > The credit-based flow control policy added in NettyClient in GIRAPH-1027 > caused the code to look complicated due to interleaving of flow control code > with the logic for sending packets and handling ACK responses. A refactoring > is needed to decouple flow control policy and NettyClient, allowing us to > develop more flow control policies regardless of requests sending and > handling logic. -- This message was sent by Atlassian JIRA (v6.3.4#6332)