[ https://issues.apache.org/jira/browse/GIRAPH-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380140#comment-15380140 ]
Hudson commented on GIRAPH-1068: -------------------------------- FAILURE: Integrated in Giraph-trunk-Commit #1642 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1642/]) [GIRAPH-1095] Performance regression after GIRAPH-1068 (edunov: [http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=b7c533baf4ce8f0fd3d3e7d521cc355e71bca797]) * giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java * giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java > Make Zookeeper accept 0 as a port number and let it choose any available free > port > ---------------------------------------------------------------------------------- > > Key: GIRAPH-1068 > URL: https://issues.apache.org/jira/browse/GIRAPH-1068 > Project: Giraph > Issue Type: Task > Reporter: Sergey Edunov > Assignee: Sergey Edunov > > We have a few use cases where having zookeeper bound to specific port is very > inconvenient. > 1) Unit tests that run in parallel. > 2) Shared clusters where multiple giraph instances can run on the same > machines. > In theory we don't need to know what port zookeeper will run on. In most > cases we're fine with any port available. > Picking any available port is currently supported by the server socket, but > is not supported in the code that parses zookeper configs (this code lives in > zookeper). > We don't have to parse configs though, as we have a way to run zookeper in > process. And in that case we can have a full control on how zookeeper is > initialized. > For this task I want to allow 0 as a port number for zookeeper. Which will > allow us to run zookeeper on any available port. And I will also remove "out > of process" zookeeper, as it clearly provides no benefits to us. > Note: it will still be possible to run external zookeper, if you have it > running somewhere as a service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)