[
https://issues.apache.org/jira/browse/GIRAPH-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891144#comment-15891144
]
ASF GitHub Bot commented on GIRAPH-1132:
----------------------------------------
Github user majakabiljo commented on a diff in the pull request:
https://github.com/apache/giraph/pull/21#discussion_r103799656
--- Diff:
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java ---
@@ -1238,5 +1239,27 @@
BooleanConfOption PREFER_IP_ADDRESSES =
new BooleanConfOption("giraph.preferIP", false,
"Prefer IP addresses instead of host names");
+
+ /**
+ * Timeout for "waitForever", when we need to wait for zookeeper.
+ * Since we should never really have to wait forever.
+ * We should only wait some reasonable but large amount of time.
+ */
+ LongConfOption WAIT_FOREVER_ZOOKEEPER_TIMEOUT_MSEC =
--- End diff --
Nit: since we are not waiting forever anymore, I'd drop word forever from
everywhere (forever and timeout have opposite meaning :-))
> Giraph jobs don't end if zookeeper dies before job starts
> ---------------------------------------------------------
>
> Key: GIRAPH-1132
> URL: https://issues.apache.org/jira/browse/GIRAPH-1132
> Project: Giraph
> Issue Type: Bug
> Reporter: Sergey Edunov
>
> There are multiple places in the Giraph code where we waitForever() on some
> event (e.g. all workers to finish or zookeeper to come up). This is in
> general bad, as any issue on other side may become undetected and make job
> run forever. We need to introduce timeout to these waits
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
