[
https://issues.apache.org/jira/browse/GIRAPH-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936985#comment-15936985
]
ASF GitHub Bot commented on GIRAPH-1138:
----------------------------------------
GitHub user majakabiljo opened a pull request:
https://github.com/apache/giraph/pull/27
[GIRAPH-1138] Don't wrap exceptions from executor service
Summary: In ProgressableUtils.getResultsWithNCallables we wrap exceptions
from underlying threads, making logs hard to read. We should re-throw original
exception when possible.
Test Plan: Ran a job which fails in one of input threads before and after
change, verified exception is clear now
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/majakabiljo/giraph exceptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/giraph/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit a460f582d9b8aa875cb32ca4f8dae1c320e9ac23
Author: Maja Kabiljo <majakabi...@fb.com>
Date: 2017-03-22T19:39:19Z
[GIRAPH-1138] Don't wrap exceptions from executor service
Summary: In ProgressableUtils.getResultsWithNCallables we wrap exceptions
from underlying threads, making logs hard to read. We should re-throw original
exception when possible.
Test Plan: Ran a job which fails in one of input threads before and after
change, verified exception is clear now
----
> Don't wrap exceptions from executor service
> -------------------------------------------
>
> Key: GIRAPH-1138
> URL: https://issues.apache.org/jira/browse/GIRAPH-1138
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
>
> In ProgressableUtils.getResultsWithNCallables we wrap exceptions from
> underlying threads, making logs hard to read. We should re-throw original
> exception when possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
