[ https://issues.apache.org/jira/browse/GIRAPH-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951648#comment-15951648 ]
ASF GitHub Bot commented on GIRAPH-1141: ---------------------------------------- Github user dlogothetis commented on a diff in the pull request: https://github.com/apache/giraph/pull/33#discussion_r109250592 --- Diff: giraph-core/src/main/java/org/apache/giraph/job/CombinedWorkerProgress.java --- @@ -204,4 +215,19 @@ public String toString() { } return sb.toString(); } + + /** + * Check if this instance made progress from another instance + * + * @param lastProgress Instance to compare with + * @return True iff progress was made + */ + public boolean madeProgressFrom(CombinedWorkerProgress lastProgress) { --- End diff -- Why not use the underlying raw numbers instead of the string? For instance, small changes in memory may not really mean progress. > Kill the job if no progress is being made > ----------------------------------------- > > Key: GIRAPH-1141 > URL: https://issues.apache.org/jira/browse/GIRAPH-1141 > Project: Giraph > Issue Type: New Feature > Reporter: Maja Kabiljo > Assignee: Maja Kabiljo > Priority: Minor > > Sometimes jobs can get stuck for various reasons, it's better to have an > option to kill them then to keep them running holding resources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)