[
https://issues.apache.org/jira/browse/GIRAPH-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200863#comment-16200863
]
ASF GitHub Bot commented on GIRAPH-1163:
----------------------------------------
Github user majakabiljo commented on a diff in the pull request:
https://github.com/apache/giraph/pull/52#discussion_r144118481
--- Diff:
giraph-core/src/main/java/org/apache/giraph/job/JobProgressTracker.java ---
@@ -43,13 +43,14 @@
void logInfo(String logLine);
/**
- * Call this when you want to log an error line from any mapper to
command
- * line
+ * Call this when you want to log an error line and exception
+ * object from any mapper to command line
*
* @param logLine Line to log
+ * @param exByteArray Exception byte array
--- End diff --
Nit: add a comment here that KryoWritableWrapper.tryConvertFromByteArray
can be used to get exception object back. (if this was java 8 I'd suggest
having another method which takes Exception parameter and have default
implementation of this one calling it, but it's not :-( )
> Changes to support sending exceptions over thrift calls.
> --------------------------------------------------------
>
> Key: GIRAPH-1163
> URL: https://issues.apache.org/jira/browse/GIRAPH-1163
> Project: Giraph
> Issue Type: Bug
> Reporter: Yuksel Akinci
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
