[ https://issues.apache.org/jira/browse/GIRAPH-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234787#comment-16234787 ]
ASF GitHub Bot commented on GIRAPH-1164: ---------------------------------------- GitHub user dlogothetis opened a pull request: https://github.com/apache/giraph/pull/53 Set mapred.job.tracker/mapred.local.dir in InternalVertexRunner https://issues.apache.org/jira/browse/GIRAPH-1164 The mapred.job.tracker and mapred.local.dir are always expected when the InternalVertexRunner is used but they are not set explicitly. Instead, they are expected to be loaded from an external options file (or passed as parameters from the tests). Setting them explicitly while stile allowing them to be overriden makes more sense. Tests: - mvn clean install - Run unit tests that do not explicitly set these options. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dlogothetis/giraph internal_runner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 ---- commit 21be46136061be9e22309fa7be335d1eb8f73d12 Author: Dionysios Logothetis <dionys...@fb.com> Date: 2017-11-01T21:40:08Z Set mapred.job.tracker/mapred.local.dir in InternalVertexRunner ---- > Set mapred.job.tracker/mapred.local.dir options in InternalVertexRunner > ----------------------------------------------------------------------- > > Key: GIRAPH-1164 > URL: https://issues.apache.org/jira/browse/GIRAPH-1164 > Project: Giraph > Issue Type: Improvement > Reporter: Dionysios Logothetis > > The mapred.job.tracker and mapred.local.dir are always expected when the > InternalVertexRunner is used but they are not set explicitly. Instead, they > are expected to be loaded from an external options file (or passed as > parameters from the tests). Setting them explicitly while stile allowing > them to be overriden makes more sense. -- This message was sent by Atlassian JIRA (v6.4.14#64029)