[
https://issues.apache.org/jira/browse/GIRAPH-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347079#comment-16347079
]
ASF GitHub Bot commented on GIRAPH-1168:
----------------------------------------
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/57
Outedges factory
Sometimes the instantiation of an OutEdges implementation might have large
overhead, e.g. if it access the configuration. Instead of creating it
directly, introduce a factory class that can be instantiated once.
https://issues.apache.org/jira/browse/GIRAPH-1168
Testing:
- mvn clean install
- internal unit tests & snapshot tests
- run with large job with custom OutEdges factory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlogothetis/giraph outedges_factory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/giraph/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit 9a8b0e33b58525e7fcab99ddbf80d1cb1767250a
Author: Dionysios Logothetis <dlogothetis@...>
Date: 2018-01-31T00:12:39Z
Create OutEdges instances through factory class
commit 684010024a57e463ca88d3c0e189ca7d5c7b46fc
Author: Dionysios Logothetis <dlogothetis@...>
Date: 2018-01-31T16:08:33Z
Add factory for input OutEdges
----
> Instantiate OutEdges through Factory class
> ------------------------------------------
>
> Key: GIRAPH-1168
> URL: https://issues.apache.org/jira/browse/GIRAPH-1168
> Project: Giraph
> Issue Type: Improvement
> Reporter: Dionysios Logothetis
> Priority: Major
>
> Sometimes the instantiation of an OutEdges implementation might have large
> overhead, e.g. if it access the configuration. Instead of creating it
> directly, introduce a factory class that can be instantiated once.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
