[
https://issues.apache.org/jira/browse/GIRAPH-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430756#comment-16430756
]
ASF GitHub Bot commented on GIRAPH-1185:
----------------------------------------
Github user majakabiljo commented on a diff in the pull request:
https://github.com/apache/giraph/pull/69#discussion_r180135213
--- Diff:
giraph-core/src/main/java/org/apache/giraph/writable/kryo/KryoSimpleWrapper.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.giraph.writable.kryo;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+
+import com.esotericsoftware.kryo.io.Input;
+import com.esotericsoftware.kryo.io.Output;
+import org.apache.hadoop.io.Writable;
+
+/**
+ * Generic wrapper object, making any object writable.
+ *
+ * Unlike KryoWritableWrapper, this wrapper does not
+ * support recursive/nested objects.
+ *
+ * Optimized for performance,
+ *
+ *
+ * @param <T> Object type
+ */
+public class KryoSimpleWrapper<T> implements Writable {
--- End diff --
What's the difference between this and KryoWritableWrapper, when should we
use one and when the other?
> Adding faster serialization classes.
> ------------------------------------
>
> Key: GIRAPH-1185
> URL: https://issues.apache.org/jira/browse/GIRAPH-1185
> Project: Giraph
> Issue Type: Improvement
> Reporter: Yuksel Akinci
> Priority: Major
>
> These changes add two new kryo serialization classes (KryoSimpleWritable and
> KryoSimpleWrapper) which disable reference tracking at the expense of not
> supporting recursive and nested structures. Disabling reference tracking
> significantly improves the serialization performance. One a sample pipeline,
> the running time reduced from 75 minutes to 5 minutes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
