[
https://issues.apache.org/jira/browse/GIRAPH-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491454#comment-16491454
]
ASF GitHub Bot commented on GIRAPH-299:
---------------------------------------
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/75
Removed unused field in BspServiceMaster
https://issues.apache.org/jira/projects/GIRAPH/issues/GIRAPH-299
This field is not used.
Tests:
mvn clean install
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlogothetis/giraph unused_field
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/giraph/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 70501e718baded0e8dd4675d66de7dd9bd6bb173
Author: Dionysios Logothetis <dlogothetis@...>
Date: 2018-05-26T01:42:40Z
Removed unused field in BspServiceMaster
----
> Remove unused field in BspServiceMaster
> ---------------------------------------
>
> Key: GIRAPH-299
> URL: https://issues.apache.org/jira/browse/GIRAPH-299
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 1.0.0
> Reporter: Eli Reisman
> Assignee: Dionysios Logothetis
> Priority: Trivial
> Labels: newbie
> Fix For: 1.0.0
>
> Attachments: GIRAPH-299-2.patch, GIRAPH-299-3.patch, GIRAPH-299.patch
>
>
> GIRAPH-275 was a victim of this weekend's outage of the JIRA site. When I
> rebased the patch, I did it from a version that was not the last one I
> uploaded before said outage.
> When I rebased the patch today, my most current version was not available to
> work from. So I forgot to perform the last fix it needed: to take the
> "localityLimit" constant on line 138 (used on line 536) of
> BspServiceMaster.java and make it static, and to change the name to
> LOCALITY_LIMIT to match proper convention.
> For those that already know how to create and upload a patch, please let this
> wait, its a perfect chance for someone new to submitting patches (and to
> Giraph) to test drive the process. Thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
