[
https://issues.apache.org/jira/browse/GIRAPH-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619571#comment-16619571
]
ASF GitHub Bot commented on GIRAPH-1200:
----------------------------------------
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/83#discussion_r218552959
--- Diff:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -966,22 +991,23 @@ public boolean apply(RequestInfo requestInfo) {
(writeFuture.isDone() && !writeFuture.isSuccess()))) ||
(requestInfo.getElapsedMsecs() > maxRequestMilliseconds);
}
- });
+ }, networkRequestsResentForTimeout);
}
/**
* Resend requests which satisfy predicate
- *
- * @param shouldResendRequestPredicate Predicate to use to check whether
+ * @param shouldResendRequestPredicate Predicate to use to check whether
* request should be resent
+ * @param counter Counter to increment for every resent network request
*/
private void resendRequestsWhenNeeded(
- Predicate<RequestInfo> shouldResendRequestPredicate) {
+ Predicate<RequestInfo> shouldResendRequestPredicate,
+ GiraphHadoopCounter counter) {
// Check if there are open requests which have been sent a long time
ago,
// and if so, resend them.
List<ClientRequestId> addedRequestIds = Lists.newArrayList();
List<RequestInfo> addedRequestInfos = Lists.newArrayList();
- // Check all the requests for problems
+ // Check all the requests for problemsAggregate vertices
--- End diff --
This comment doesn't look right
> Add counters for network request resends
> ----------------------------------------
>
> Key: GIRAPH-1200
> URL: https://issues.apache.org/jira/browse/GIRAPH-1200
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
>
> Expose statistics around network requests which we had to resend.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
