Github user majakabiljo commented on a diff in the pull request:
https://github.com/apache/giraph/pull/84#discussion_r218551052
--- Diff:
giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java ---
@@ -1379,9 +1379,15 @@ private boolean barrierOnWorkerList(String
finishedWorkerPath,
// Wait for a signal or timeout
boolean eventTriggered = event.waitMsecs(eventLoopTimeout);
+
+ // If the event was triggered, we reset it. In the next loop run, we
will
+ // read ZK to get the new hosts.
+ if (eventTriggered) {
+ event.reset();
+ }
+
long elapsedTimeSinceRegularRunMsec = System.currentTimeMillis() -
lastRegularRunTimeMsec;
- event.reset();
--- End diff --
Making sure I understand what's happening, does reodering of commands here
makes no difference and the fix is about only clearing event if it triggered?
---
