[
https://issues.apache.org/jira/browse/GIRAPH-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677724#comment-16677724
]
ASF GitHub Bot commented on GIRAPH-1211:
----------------------------------------
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/93#discussion_r231387974
--- Diff:
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java ---
@@ -690,6 +690,12 @@
new IntConfOption("giraph.maxRequestMilliseconds",
MINUTES.toMillis(10),
"Milliseconds for a request to complete (or else resend)");
+ /** Milliseconds for a request to complete (or else resend) */
--- End diff --
Comment seems inaccurate.
> Make retrying to send network requests after timeout optional
> -------------------------------------------------------------
>
> Key: GIRAPH-1211
> URL: https://issues.apache.org/jira/browse/GIRAPH-1211
> Project: Giraph
> Issue Type: New Feature
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Major
>
> Using counters added in GIRAPH-1205 we were able to confirm that resending
> network requests after timeout almost never succeeds, so add an option to
> fail early instead of keep trying to resend these network requests
> indefinitely.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
