[
https://issues.apache.org/jira/browse/GIRAPH-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177959#comment-17177959
]
Randy Hu commented on GIRAPH-1187:
----------------------------------
[~dlogothetis], it's currently initialized in super step initialization
(GraphTaskManager.newSuperstep), and has dependencies on the method parameter,
don't know if possible to get an instance of SuperstepMetricsRegistry in
installGCMonitoring. We probably still want to keep the existing logic inside
newSuperstep, so the counter would be per super step , which provides better
insights than a single global counter.
Since the data loading could vary significantly depending on user config, we
might just simply ignore the counter in data loading stage since that's not the
core of Giraph, then it would be a straight forward fix.
> NPE in worker GC listener
> --------------------------
>
> Key: GIRAPH-1187
> URL: https://issues.apache.org/jira/browse/GIRAPH-1187
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 1.2.0
> Environment: Giraph 1.2.0 running in M/R on Hadoop 2.6
> Reporter: Randy Hu
> Priority: Critical
>
> Likely the GC notification happened before any super step, in which case "
> gcTimeMetric" is not initialized at all. Here is stack trace:
>
> java.lang.NullPointerException at
> org.apache.giraph.graph.GraphTaskManager$1.handleNotification(GraphTaskManager.java:667)
> at
> sun.management.NotificationEmitterSupport.sendNotification(NotificationEmitterSupport.java:156)
> at
> sun.management.GarbageCollectorImpl.createGCNotification(GarbageCollectorImpl.java:143)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
