dlogothetis commented on a change in pull request #150:
URL: https://github.com/apache/giraph/pull/150#discussion_r619748156



##########
File path: giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
##########
@@ -1335,5 +1346,17 @@
   BooleanConfOption FAIL_ON_EMPTY_INPUT = new BooleanConfOption(
       "giraph.failOnEmptyInput", true,
       "Whether to fail the job or just warn when input is empty");
+
+  /** SSLConfigReader class - optional */
+  ClassConfOption<SSLConfigReader> SSL_CONFIG_READER_CLASS =
+          ClassConfOption.create("giraph.sslConfigReader",
+              null, SSLConfigReader.class,
+                  "SSLConfigReader class - optional");
+
+  /** SSLEventHandler class - optional */
+  ClassConfOption<SSLEventHandler> SSL_EVENT_HANDLER_CLASS =
+    ClassConfOption.create("giraph.sslEventHandler",
+      null, SSLEventHandler.class,
+      "SSLEventHandler class - optional");

Review comment:
       Can you describe in the documentation what these are?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to