[ https://issues.apache.org/jira/browse/GIRAPH-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517455#comment-17517455 ]
Swarup Patra commented on GIRAPH-545: ------------------------------------- There Will Be Trips An Error Subject But That Was Tolled Freely support That Was Perfect Education That Will Be Nothing Else More Track Than appel Describe thn > Improve Facebook Hadoop dependency > ---------------------------------- > > Key: GIRAPH-545 > URL: https://issues.apache.org/jira/browse/GIRAPH-545 > Project: Giraph > Issue Type: Bug > Reporter: Nitay Joffe > Assignee: Nitay Joffe > Priority: Major > Attachments: GIRAPH-545.patch > > > The Facebook Hadoop dependency uses a local path (systemPath in maven) which > is bad for many reasons. See e.g. > http://docs.codehaus.org/display/MAVENUSER/Dependency+Scopes (the part about > system scope). Amongst the problems are: > - We package the jar ourselves in our lib/ folder > - Anyone depending on Giraph needs to download jars themselves and put them > in right place, but we don't supply the jars. > - There is no javadoc or sources jar which comes with most open source maven > projects and is really handy > So I went ahead and created a package from Facebook's code on Github and > published the jar to maven central. This diff updates our code to use that, > which fixes all of the problems mentioned above. -- This message was sent by Atlassian Jira (v8.20.1#820001)