[
https://issues.apache.org/jira/browse/GOBBLIN-1227?focusedWorklogId=467548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467548
]
ASF GitHub Bot logged work on GOBBLIN-1227:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/20 20:18
Start Date: 06/Aug/20 20:18
Worklog Time Spent: 10m
Work Description: htran1 opened a new pull request #3073:
URL: https://github.com/apache/incubator-gobblin/pull/3073
… existence indicator
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1277
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
The CopyDataPublisher uses HadoopUtils.renameRecursively() to publish the
staged data to the root path "/". HadoopUtils.renameRecursively() will check
for the existence of the target directory and its parent directory and call
mkdirs to create missing directories if the parent directory does not exist.
This check may return an AccessDeniedException if permissions are limited on
the parent directory.
For directories, treat the AccessDeniedException as an indicator of
existence to allow the recursive renaming to proceed in this scenario.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
testRenameRecursivelyWithAccessDeniedOnExistenceCheck
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 467548)
Remaining Estimate: 0h
Time Spent: 10m
> Treat AccessDeniedException in RenameRecursively as an existence indicator
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1227
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1227
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The CopyDataPublisher uses
> HadoopUtils.renameRecursively() to publish the staged data to the root path
> "/". HadoopUtils.renameRecursively() will check for the existence of the
> target directory and its parent directory and call mkdirs to create missing
> directories if the parent directory does not exist.
> This check may return an AccessDeniedException if permissions are limited on
> the parent directory.
> For directories, treat the AccessDeniedException as an indicator of existence
> to allow the recursive renaming to proceed in this scenario.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
