[
https://issues.apache.org/jira/browse/GOBBLIN-1226?focusedWorklogId=468866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468866
]
ASF GitHub Bot logged work on GOBBLIN-1226:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/20 20:14
Start Date: 10/Aug/20 20:14
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #3072:
URL:
https://github.com/apache/incubator-gobblin/pull/3072#issuecomment-671565592
+1 LGTM,
@hkoosha , It would be also good to place this dependencies at parent level,
as a core feature available for all modules in Gobblin.
@sv2000 can u pls help review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 468866)
Time Spent: 20m (was: 10m)
> Lombok should not leak into runtime dependencies.
> -------------------------------------------------
>
> Key: GOBBLIN-1226
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1226
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Koosha Hosseiny
> Priority: Trivial
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Lombok is a cool tool (although IMHO not worth it's troubles, considering
> generated code is harder to debug, incompatibilities in bytecode, line
> version mismatch in debugger, etc, etc) which promises to have zero runtime
> dependencies.
> It is also *strongly* advised by its developers that it should be present on
> the classpath only during compilation/code generation and _not at all_,
> during runtime. (I don't have an exact reference at hand but it can be
> searched in the lombok google forum).
> Lombok in runtime's classpath is considered not only a bad practice but wrong
> usage of lombok.
> The issue it caused me was that it brings an older version of guava into path.
> I propose the `compile ...lombok` in `build.gradle` be changed to
> `compileOnly`. This has zero effects on any current project using gobblin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
