[
https://issues.apache.org/jira/browse/GOBBLIN-1222?focusedWorklogId=470384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470384
]
ASF GitHub Bot logged work on GOBBLIN-1222:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/20 19:47
Start Date: 13/Aug/20 19:47
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3070:
URL: https://github.com/apache/incubator-gobblin/pull/3070#discussion_r470205471
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java
##########
@@ -139,17 +141,28 @@ public FileAwareInputStreamDataWriter(State state, int
numBranches, int branchId
URI uri = URI.create(uriStr);
this.fs = FileSystem.get(uri, conf);
this.fileContext = FileContext.getFileContext(uri, conf);
+ this.copyableDatasetMetadata =
Review comment:
Why are you moving this code block above ?
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveDataset.java
##########
@@ -85,6 +85,8 @@
public static final String DATASET_NAME_PATTERN_KEY =
"hive.datasetNamePattern";
public static final String DATABASE = "Database";
public static final String TABLE = "Table";
+ public static final String DATASET_STAGING_PATH = "dataset.staging.path";
+ public static final String DATASET_PREFIX_REPLACEMENT =
"hive.dataset.copy.target.table.prefixReplacement";
Review comment:
Can you use the existing variable for this instead of inventing a new
variable ?
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveDataset.java
##########
@@ -102,6 +105,7 @@
// Only set if table has exactly one location
protected final Optional<Path> tableRootPath;
+ protected final Path tableLocation;
Review comment:
This is just a local variable and don't have to be a field for this
class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 470384)
Time Spent: 2h 20m (was: 2h 10m)
> Create right abstraction to assemble dataset staging dir for Hive dataset
> finder
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1222
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1222
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Vaibhav Arya
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
